[Mesa-dev] [PATCH 3/3] anv: Don't record the handle in the relocation

[Jason Ekstrand]

On Thu, May 11, 2017 at 12:42 AM, Chris Wilson <chris at chris-wilson.co.uk>
wrote:

> On Wed, May 10, 2017 at 04:08:55PM -0700, Jason Ekstrand wrote:
> > We use the look-up table mechanism for relocations so this isn't the
> > value we want.  The correct value is filled out at execbuf2 time by
> > anv_cmd_buffer_process_relocs.
> > ---
> >  src/intel/vulkan/anv_batch_chain.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/intel/vulkan/anv_batch_chain.c
> b/src/intel/vulkan/anv_batch_chain.c
> > index cc4f92e..5811503 100644
> > --- a/src/intel/vulkan/anv_batch_chain.c
> > +++ b/src/intel/vulkan/anv_batch_chain.c
> > @@ -165,7 +165,7 @@ anv_reloc_list_add(struct anv_reloc_list *list,
>
> Just before this is a comment talking about using LUT - you already are.
> It's relevant as the invalid target_handle for LUT is -1 and 0 for !LUT.
>

Right.  So now the kernel will fail to execbuf if we ever don't fill the
value out rather than just doing the wrong thing.  Would you like a comment
about that in the commit message or something?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170511/00d7fc41/attachment-0001.html>