[Mesa-dev] [PATCH 08/24] anv/image: Remove incorrect assertion in anv_BindImage

Nanley Chery nanleychery at gmail.com
Thu May 11 19:05:15 UTC 2017


According to the Linux kernel sources, the ioctl in anv_gem_mmap() will
not fail if the size isn't a multiple of 4KB.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
---
 src/intel/vulkan/anv_image.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 30cdfdb0e5..6b6cc324b3 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -414,11 +414,10 @@ VkResult anv_BindImageMemory(
 
    if (image->aux_surface.isl.size > 0) {
 
-      /* The offset and size must be a multiple of 4K or else the
-       * anv_gem_mmap call below will fail.
+      /* The offset must be a multiple of 4K or else the anv_gem_mmap call
+       * below will fail.
        */
       assert((image->offset + image->aux_surface.offset) % 4096 == 0);
-      assert(image->aux_surface.isl.size % 4096 == 0);
 
       /* Auxiliary surfaces need to have their memory cleared to 0 before they
        * can be used.  For CCS surfaces, this puts them in the "resolved"
-- 
2.12.2



More information about the mesa-dev mailing list