[Mesa-dev] [PATCH] nv50/ir: Report wrong prog types using proper var

Samuel Pitoiset samuel.pitoiset at gmail.com
Fri May 12 09:05:00 UTC 2017


Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 05/12/2017 11:01 AM, Pierre Moreau wrote:
> Coverity caught the use of the uninitialised variable `type`.
> However, it was `info->type`, which is initialised, which was meant to
> be used.
> 
> CID: 1406000
> Reported-by: Ilia Mirkin <imirkin at alum.mit.edu>
> Fixes: b490ca9a387d ("nv50/ir: Fail if encountering unknown shader type")
> Signed-off-by: Pierre Moreau <pierre.morrow at free.fr>
> ---
>   src/gallium/drivers/nouveau/codegen/nv50_ir.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp
> index a000bcbd32..21641a4746 100644
> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp
> @@ -1214,7 +1214,7 @@ nv50_ir_generate_code(struct nv50_ir_prog_info *info)
>      PROG_TYPE_CASE(FRAGMENT, FRAGMENT);
>      PROG_TYPE_CASE(COMPUTE, COMPUTE);
>      default:
> -      INFO_DBG(info->dbgFlags, VERBOSE, "unsupported program type %u\n", type);
> +      INFO_DBG(info->dbgFlags, VERBOSE, "unsupported program type %u\n", info->type);
>         return -1;
>      }
>      INFO_DBG(info->dbgFlags, VERBOSE, "translating program of type %u\n", type);
> 


More information about the mesa-dev mailing list