[Mesa-dev] [PATCH 24/24] i965: Simplify get_l3_way_size() function

[Francisco Jerez]

Francisco Jerez <currojerez at riseup.net> writes:

> Anuj Phogat <anuj.phogat at gmail.com> writes:
>
>> Cherryview and Broxton are always gt1. So, remove the redundant checks.
>>
>> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
>> ---
>>  src/intel/common/gen_l3_config.c | 10 ++++------
>>  1 file changed, 4 insertions(+), 6 deletions(-)
>>
>> diff --git a/src/intel/common/gen_l3_config.c b/src/intel/common/gen_l3_config.c
>> index 4fe3503..0720079 100644
>> --- a/src/intel/common/gen_l3_config.c
>> +++ b/src/intel/common/gen_l3_config.c
>> @@ -258,13 +258,11 @@ get_l3_way_size(const struct gen_device_info *devinfo)
>>     if (devinfo->is_baytrail)
>>        return 2;
>>  
>> -   else if (devinfo->gt == 1 ||
>> -            devinfo->is_cherryview ||
>> -            devinfo->is_broxton)
>> -      return 4;
>> +   /* Cherryview and Broxton are always gt1 */
>> +   if (devinfo->gt == 1)
>> +       return 4;
>>  
>
> I don't feel that replacing self-documenting code with equivalent
> non-self-documenting code plus a comment containing the same information
> as the code you removed actually simplifies anything.  That said, this
> function *could* be simplified appreciably by using the l3_banks field
> you added to gen_device_info to calculate the way size consistently
> across all gens up to Gen10.  Care to do that instead?
>

Please consider the above a NAK of this patch in its current form.

>> -   else
>> -      return 8 * devinfo->num_slices;
>> +   return 8 * devinfo->num_slices;
>>  }
>>  
>>  /**
>> -- 
>> 2.9.3
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170513/b5e3b83a/attachment-0001.sig>