[Mesa-dev] [PATCH] ac/surface: fix regression for S8 on radv.

Dave Airlie airlied at gmail.com
Sun May 14 23:58:05 UTC 2017


From: Dave Airlie <airlied at redhat.com>

S8 surfaces have no non-stencil levels, so compute level
can fail for them, but we should continue to compute the levels
for the stencil later.

This is what we did in radv previous to fix this, but maybe
we can do something cleaner?
---
 src/amd/common/ac_surface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c
index 376eb47..ae2c10a 100644
--- a/src/amd/common/ac_surface.c
+++ b/src/amd/common/ac_surface.c
@@ -586,7 +586,7 @@ static int gfx6_compute_surface(ADDR_HANDLE addrlib,
 				       &AddrSurfInfoIn, &AddrSurfInfoOut,
 				       &AddrDccIn, &AddrDccOut, &AddrHtileIn, &AddrHtileOut);
 		if (r)
-			return r;
+			break;
 
 		if (level == 0) {
 			surf->surf_alignment = AddrSurfInfoOut.baseAlign;
-- 
2.9.3



More information about the mesa-dev mailing list