[Mesa-dev] [PATCH v2 07/27] configure: error out when building GLX w/o the X11 platform

[Emil Velikov]

On 8 May 2017 at 01:35, Eric Engestrom <eric at engestrom.ch> wrote:
> On Thursday, 2017-05-04 17:29:52 +0100, Emil Velikov wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> Building EGL/Vulkan/other without X11, while GLX is enabled is confusing
>> and misleading. In practise anyone aiming at the former will also
>> disable GLX.
>>
>> The inverse (some examples below) should still work:
>>  ./configure --disable-glx --with-platforms=x11 --with-vulkan-drivers=intel
>>  ./configure --disable-glx --with-platforms=x11 --enable-egl
>>
>> Keep in mind that the X11 platform is enabled, by default.
>>
>> Cc: <mesa-stable at lists.freedesktop.org>
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> ---
>>  configure.ac | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/configure.ac b/configure.ac
>> index d76ad5039a2..920e3c53e7b 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1724,6 +1724,12 @@ for plat in $platforms; do
>>       esac
>>  done
>>
>> +if test "x$enable_glx" != xno; then
>> +    if ! echo "$platforms" | grep -q 'x11'; then
>> +        AC_MSG_ERROR([Building without the x11 platform as GLX is enabled, is not supported])
>
> "Building GLX without the x11 platform is not supported"
>
> Patches 1-11 are
> Reviewed-by: Eric Engestrom <eric at engestrom.ch>
>
Thanks Eric.

> I don't seem to have received patches 12-27 of this series though?
>
Git send-email tripped on a malformed email in 12. The rest of the
series is was sent shortly after the first 11 patches. See [1] or [2]

-Emil

[1] https://lists.freedesktop.org/archives/mesa-dev/2017-May/154492.html
[2] https://patchwork.freedesktop.org/bundle/evelikov/platforms-for-all/