[Mesa-dev] [PATCH 0/4] radeonsi: move TGSI memory/texture opcode handling out of si_shader.c

Nicolai Hähnle nhaehnle at gmail.com
Mon May 15 21:43:56 UTC 2017


Hi all,

This series is only moving code around. si_shader.c has become pretty
unwieldy over time, and handling of memory/texture opcodes is a big chunk
that can be nicely extracted elsewhere without a lot of dependencies. It
is analogous to the ALU ops that are already separate.

Even after this refactoring, si_shader.c still has more than 7k lines of
code, but it's less clear how it can be split. There are some obvious
remaining TGSI opcodes, though they amount to much less code. Most of the
rest falls under the vague headline of "ABI handling".

Please review!
Thanks,
Nicolai
--
 .../drivers/radeonsi/Makefile.sources        |    1 +
 src/gallium/drivers/radeonsi/si_shader.c     | 2016 +---------------
 .../drivers/radeonsi/si_shader_internal.h    |   14 +
 .../drivers/radeonsi/si_shader_tgsi_mem.c    | 1883 +++++++++++++++
 .../drivers/radeonsi/si_shader_tgsi_setup.c  |    1 +
 5 files changed, 1984 insertions(+), 1931 deletions(-)



More information about the mesa-dev mailing list