[Mesa-dev] [PATCH 2/4] mesa: drop APPLE_vertex_array_object support

[Ian Romanick]

On 05/15/2017 05:51 PM, Timothy Arceri wrote:
> On 16/05/17 10:47, Kenneth Graunke wrote:
>> On Monday, May 15, 2017 4:06:31 PM PDT Timothy Arceri wrote:
>>> On 16/05/17 08:13, Ian Romanick wrote:
>>>> On 04/23/2017 10:28 PM, Timothy Arceri wrote:
>>>>
>>>>> diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
>>>>> b/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
>>>>> deleted file mode 100644
>>>>> index 7312f9b..0000000
>>>>> --- a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
>>>>> +++ /dev/null
>>>>> @@ -1,27 +0,0 @@
>>>>
>>>>
>>>> So... I'm fairly sure this is going to break loading a _dri.so built
>>>> without this patch by a libGL built with this patch.
>>>
>>> I recall something like this coming up a few year ago, can you remind me
>>> again why this is a problem? Shouldn't these be updated in sync?
>>
>> Out-of-tree drivers, such as the legacy DRI1 drivers, won't be updated
>> in sync (or likely ever).  I believe there are also at least two closed
>> source drivers (though that isn't a good reason not to do this change).
>>
>> Ian might recall some other reasons.
>>
>> Leaving the functions there, but having them return INVALID_OPERATION
>> (like generic_nop does) would likely route around this issue.
>>
>> Not sure whether deleting support for this extension is a good idea
>> or not.  I can't think of any applications that use it offhand, but
>> I haven't really looked into it either...if the NVIDIA blob doesn't
>> expose it, that's a good data point...
> 
> The commit message has been deleted from this thread but it included:
> 
> "For reference the Nvidia blob doesn't expose this extension."

Right.  I think removing support for the extension is fine.  I added
support for this before the ARB extension existed, but I don't know of
any applications on non-OS X platforms that use it.