[Mesa-dev] [PATCH 2/4] mesa: drop APPLE_vertex_array_object support

[Emil Velikov]

On 16 May 2017 at 14:26, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 16 May 2017 at 02:07, Timothy Arceri <tarceri at itsqueeze.com> wrote:
>> On 16/05/17 10:47, Kenneth Graunke wrote:
>>>
>>> On Monday, May 15, 2017 4:06:31 PM PDT Timothy Arceri wrote:
>>>>
>>>> On 16/05/17 08:13, Ian Romanick wrote:
>>>>>
>>>>> On 04/23/2017 10:28 PM, Timothy Arceri wrote:
>>>>>
>>>>>> diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
>>>>>> b/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
>>>>>> deleted file mode 100644
>>>>>> index 7312f9b..0000000
>>>>>> --- a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
>>>>>> +++ /dev/null
>>>>>> @@ -1,27 +0,0 @@
>>>>>
>>>>>
>>>>>
>>>>> So... I'm fairly sure this is going to break loading a _dri.so built
>>>>> without this patch by a libGL built with this patch.
>>>>
>>>>
>>>> I recall something like this coming up a few year ago, can you remind me
>>>> again why this is a problem? Shouldn't these be updated in sync?
>>>
>>>

> On the patch itself I need to double-check, but I think it would be
> fine. Please don't quote me :-)
>
Double-checking:
 - linux_gl_abi must stay as-is, period.
 - known_dispatch can:
a) drop symbols, only if marked as exec=skip or exec=dynamic
Note that changing the symbols' exec model and then removing them is a no-go.
For example 5aaabd7630ca6fd72a3333687249574e6fcbe663

b) grow new symbols - those symbols are normally not be annotated as
exec=skip or exec=dynamic
504f5f9d1a4fb5a0ddc8a5d0bf73fd6eba96b1d0

c) rename symbols - only if the new/old names are aliases of one another
8e3a7c620440fab014e41b18badf73ca9dfdba45

ian, others, can anyone confirm if the above is correct?
Once confirmed I will prep a patch that adds a bunch of comments in the test.

-Emil