[Mesa-dev] [PATCH] glxglvnddispatch: Add missing dispatch for GetDriverConfig

[Emil Velikov]

Hi Hans

Please poke if patches fall through the cracks.

On 20 March 2017 at 11:05, Hans de Goede <hdegoede at redhat.com> wrote:
> Together with some fixes to xdriinfo this fixes xdriinfo not working
> with glvnd.
>
> Since apps (xdriinfo) expect GetDriverConfig to work without going to
> need through the dance to setup a glxcontext (which is a reasonable
> expectation IMHO), the dispatch for this ends up significantly different
> then any other dispatch function.
>
> This patch gets the job done, but I'm not really happy with how this
> patch turned out, suggestions for a better fix are welcome.
>
> Cc: Kyle Brenneman <kbrenneman at nvidia.com>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
>  src/glx/g_glxglvnddispatchfuncs.c   | 18 ++++++++++++++++++
>  src/glx/g_glxglvnddispatchindices.h |  1 +
>  2 files changed, 19 insertions(+)
>
> diff --git a/src/glx/g_glxglvnddispatchfuncs.c b/src/glx/g_glxglvnddispatchfuncs.c
> index b5e3398..040cdf8 100644
> --- a/src/glx/g_glxglvnddispatchfuncs.c
> +++ b/src/glx/g_glxglvnddispatchfuncs.c
> @@ -4,6 +4,7 @@
>   */
>  #include <stdlib.h>
>
> +#include "glxclient.h"
>  #include "glxglvnd.h"
>  #include "glxglvnddispatchfuncs.h"
>  #include "g_glxglvnddispatchindices.h"
> @@ -50,6 +51,7 @@ const char * const __glXDispatchTableStrings[DI_LAST_INDEX] = {
>      __ATTRIB(GetCurrentDisplayEXT),
>      // glXGetCurrentDrawable implemented by libglvnd
>      // glXGetCurrentReadDrawable implemented by libglvnd
> +    __ATTRIB(GetDriverConfig),

Back in Nov 2016 we had a chat with Adam and if I understood things
correctly the idea was to kill off the following:

glXGetScreenDriver
glXGetDriverConfig

Neither of those is part of an extension and the only user xdriinfo,
is not that useful.
Would be great if distributions let it to rest and we don't have to
worry about it ever being around ;-)

-Emil