[Mesa-dev] [PATCH 11/43] intel/gensml: Suffix KSP0 fields on Iron Lake

[Jason Ekstrand]

On Tue, May 16, 2017 at 4:07 PM, Matt Turner <mattst88 at gmail.com> wrote:

> On Tue, May 16, 2017 at 3:45 PM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> > Iron Lake introduced the multiple KSP thing and so you have KSP0-3.
> > However, the genxml didn't have an index on the first "Kernel Start
> > Pointer" or "GRF Register Count".  Add one to match gen6+.
> > ---
> >  src/intel/genxml/gen5.xml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/intel/genxml/gen5.xml b/src/intel/genxml/gen5.xml
> > index 87377df..a521737 100644
> > --- a/src/intel/genxml/gen5.xml
> > +++ b/src/intel/genxml/gen5.xml
> > @@ -864,8 +864,8 @@
> >    </struct>
> >
> >    <struct name="WM_STATE" length="11">
> > -    <field name="Kernel Start Pointer" start="6" end="31"
> type="offset"/>
> > -    <field name="GRF Register Count" start="1" end="3" type="uint"/>
> > +    <field name="Kernel Start Pointer[0]" start="6" end="31"
> type="offset"/>
>
> I removed the brackets from the Kernel Start Pointer names in commit
> 3443bd45a3. Please just add 0 and not [0]
>

So you did!  I'll make it just 0.  I'll strip the brackets off the GRF
register counts while I'm at it.


> With that,
>
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170516/972f520b/attachment.html>