[Mesa-dev] [PATCH 1/3] etnaviv: Add support for extended texture formats

Wladimir J. van der Laan laanwj at gmail.com
Wed May 17 05:13:20 UTC 2017


On Tue, May 16, 2017 at 09:31:38PM +0200, Christian Gmeiner wrote:
> Hi Wladimir.
> 
> I started working on this topic last week and thought some time on how
> to add those ext texture formats in a clean and nice way. I come up
> with this patches:
> 
> https://github.com/austriancoder/mesa/commit/1fac9dd179976dce3d991bb0715707021c093f1a.patch
> https://github.com/austriancoder/mesa/commit/f408fc40a028fa00e87900e6fd4cce65ee6640c2.patch
> 
> IMO it is a simpler implementation as I do not need two variants of
> macros (base and extended) and there is no need for
> translate_texture_format_ext(..).
> What is your opinion about it?

Good idea, the reason I'd been using two sets of macros is the hardcoding of
TEXTURE_FORMAT#, hadn't dawned on me that TEXTURE_FORMAT_EXT also starts with
TEXTURE_FORMAT :-)

Wladimir


More information about the mesa-dev mailing list