[Mesa-dev] [PATCH 04/10] radeonsi: remove early return in si_upload_descriptors

Marek Olšák maraeo at gmail.com
Wed May 17 19:38:46 UTC 2017


From: Marek Olšák <marek.olsak at amd.com>

All updates of descriptors_dirty also set dirty_mask, so the return is
unnecessary. The next commit will want this function to be executed
even if dirty_mask == 0.
---
 src/gallium/drivers/radeonsi/si_descriptors.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c
index 177d2f3..91cc9a6 100644
--- a/src/gallium/drivers/radeonsi/si_descriptors.c
+++ b/src/gallium/drivers/radeonsi/si_descriptors.c
@@ -190,23 +190,20 @@ void si_ce_enable_loads(struct radeon_winsys_cs *ib)
 	                CONTEXT_CONTROL_LOAD_CE_RAM(1));
 	radeon_emit(ib, CONTEXT_CONTROL_SHADOW_ENABLE(1));
 }
 
 static bool si_upload_descriptors(struct si_context *sctx,
 				  struct si_descriptors *desc,
 				  struct r600_atom * atom)
 {
 	unsigned list_size = desc->num_elements * desc->element_dw_size * 4;
 
-	if (!desc->dirty_mask)
-		return true;
-
 	if (sctx->ce_ib && desc->uses_ce) {
 		uint32_t const* list = (uint32_t const*)desc->list;
 
 		if (desc->ce_ram_dirty)
 			si_ce_reinitialize_descriptors(sctx, desc);
 
 		while(desc->dirty_mask) {
 			int begin, count;
 			u_bit_scan_consecutive_range64(&desc->dirty_mask, &begin,
 						       &count);
-- 
2.7.4



More information about the mesa-dev mailing list