[Mesa-dev] [PATCH 2/4] st/mesa: silence a valgrind warning in u_threaded_context due to st_draw_vbo

[Samuel Pitoiset]

Use of uninitialized variable I guess? I would suggest to move this at 
the beginning of the function, as well as 'info.index_size = 0', but 
your call.

Except a little comment on patch 1, series is:

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 05/17/2017 09:14 PM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> ---
>   src/mesa/state_tracker/st_draw.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c
> index 019001f..fe03a4a 100644
> --- a/src/mesa/state_tracker/st_draw.c
> +++ b/src/mesa/state_tracker/st_draw.c
> @@ -177,20 +177,21 @@ st_draw_vbo(struct gl_context *ctx,
>         } else {
>            /* indices are in user space memory */
>            info.has_user_indices = true;
>            info.index.user = ib->ptr;
>         }
>   
>         setup_primitive_restart(ctx, &info);
>      }
>      else {
>         info.index_size = 0;
> +      info.has_user_indices = false;
>   
>         /* Transform feedback drawing is always non-indexed. */
>         /* Set info.count_from_stream_output. */
>         if (tfb_vertcount) {
>            if (!st_transform_feedback_draw_init(tfb_vertcount, stream, &info))
>               return;
>         }
>      }
>   
>      assert(!indirect);
>