[Mesa-dev] [PATCH v2 0/6] Various fixes to integer GetUniform*()

[Matt Turner]

On Thu, May 18, 2017 at 2:43 AM, Iago Toral Quiroga <itoral at igalia.com> wrote:
> The main change is that we now use round*() instead of IROUND*() which only
> worked for signed integer cases. I have also made it so we write
> converted unsigned values the unsigned field in the destination union and to
> cast the result from round*() to the target integer type explicitly (this is
> redundant now that we we write to the appropriate union field, but shouldn't
> hurt).
>
> The series drops the patch that added IROUNDD64 since we no longer need
> that macro and adds another patch at the end to remove the remaining uses
> of IROUND macros in this function (still used for signed integer cases) for
> the sake of consistency.

Thank you for doing this.

Assuming my suggestions to use lround/llround/etc don't cause
problems, the series is

Reviewed-by: Matt Turner <mattst88 at gmail.com>