[Mesa-dev] [PATCH] travis: Disable scons tests, since the gallium unit tests fail.

[Jose Fonseca]

I suppose the failures happen with S2TC lib-dxtn implementation. 
Because I haven't seen them failing with the old implementation, or when 
no implementation is present (as the tests will just skip.)

We could craft the test cases so they aren't sensitive to S2TC.  On the 
other hand the patent expires this year IIRC, so probably not worth 
spending time on it.

Honestly, I'm happy skipping all s3tc unit tests until we have full s3tc 
in Mesa mainline source tree.

Jose

On 22/05/17 00:33, Roland Scheidegger wrote:
> I suppose the s3tc problems should go away rather sooner than later, but
> isn't it possible to just disable the formats tests?
> 
> Roland
> 
> Am 18.05.2017 um 23:27 schrieb Eric Anholt:
>> Every push a developer does to a travis-enabled github comes back as fail,
>> because the unit tests are already failing:
>>
>>      Testing util_format_dxt5_rgba_pack_rgba_float ...
>>
>>      FAILED: 40 bd 48 90 20 01 12 20 53 76 ab 32 00 10 15 50 obtained
>>              f8 11 c5 0c 9a 73 b4 9c f6 8f ab 32 2a 9a 95 5a expected
>>
>>      Testing util_format_dxt5_rgba_unpack_rgba_float ...
>>
>>      FAILED: {0.549020, 1.000000, 0.709804, 0.972549},
>>              {0.192157, 0.333333, 0.352941, 0.972549},
>>              {0.549020, 1.000000, 0.709804, 0.972549},
>>              {0.549020, 1.000000, 0.709804, 0.066667},
>>
>> Disable them from CI until someone cares to fix them.
>> ---
>>   .travis.yml | 10 ++++++----
>>   1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 5e060d0335cb..20a97c013913 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -208,8 +208,9 @@ matrix:
>>           - SCONSFLAGS="-j4"
>>           # Explicitly disable.
>>           - SCONS_TARGET="llvm=0"
>> -        # Keep it symmetrical to the make build.
>> -        - SCONS_CHECK_COMMAND="scons llvm=0 check"
>> +        # Disable scons check until the gallium unit tests pass.
>> +        #- SCONS_CHECK_COMMAND="scons llvm=0 check"
>> +        - SCONS_CHECK_COMMAND="true"
>>         addons:
>>           apt:
>>             packages:
>> @@ -225,8 +226,9 @@ matrix:
>>           - BUILD=scons
>>           - SCONSFLAGS="-j4"
>>           - SCONS_TARGET="llvm=1"
>> -        # Keep it symmetrical to the make build.
>> -        - SCONS_CHECK_COMMAND="scons llvm=1 check"
>> +        # Disable scons check until the gallium unit tests pass.
>> +        # - SCONS_CHECK_COMMAND="scons llvm=1 check"
>> +        - SCONS_CHECK_COMMAND="true"
>>           - LLVM_VERSION=3.3
>>           - LLVM_CONFIG="llvm-config-${LLVM_VERSION}"
>>         addons:
>>
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>