[Mesa-dev] [RFC PATCH 29/65] tgsi: add new Bindless flag to tgsi_instruction_texture

[Samuel Pitoiset]

On 05/22/2017 07:06 PM, Marek Olšák wrote:
> On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> Old-style images are identified using TGSI_FILE_SAMPLER, but
>> bindless samplers can be TGSI_FILE_CONSTANT or TGSI_FILE_TEMPORARY.
>>
>> To avoid backend compilers to be confused, this adds a new flag
>> that will only be set for bindless samplers.
> 
> Sorry, I don't understand it. Why is it necessary? It seems to me that
> this is enough to tell whether the sampler is bindless: File !=
> TGSI_FILE_SAMPLER && File != TGSI_FILE_IMAGE.

Initially, it seemed to work without the new Bindless flags but piglit 
reported me some issues at some point. I don't remember exactly the 
fails but I will try again without these flags. I do agree that should 
work as-is.

> 
> Marek
>