[Mesa-dev] [PATCH] configure.ac: Add --with-wayland-scanner-path

[Emil Velikov]

Hi Jussi,

On 23 May 2017 at 09:13, Jussi Kukkonen <jussi.kukkonen at intel.com> wrote:
> Modify wayland-scanner lookup: Use the path given by pkg-config
> but offer an option to override the path with
> "--with-wayland-scanner-path=PATH". The latter is useful for
> cross-compile situations.
>
> AC_PATH_PROG is no longer used (if the scanner is installed it should
> get found by pkg-config). AC_SUBST is added so the output variable is
> created when only the configure option is used.
> ---
>
> My goal is to standardize wayland-scanner usage in a way that does not
> require patching when cross-compiling in Yocto (the detailed issue is
> that in Yocto pkg-config will return a "wayland_scanner" variable but
> that will contain a _target path_ when we would like to use a native
> sysroot path instead).
>
> I've sent a similar patch to weston and intend to fix other projects
> if these two patches are well received.
>
I might have misread something, but on a quick look the patch does not
look quite right. Stepping aside for a moment,

Can you explain clearly what's happening/wrong in the whole scenario?
 - Yocto does has A stage where it does X.
 - Then it proceeds to B... at which point $file
foo/wayland-scanner.pc gets picked
 - That results in an error due to variable containing $bar, due to
the $step above

Thanks
Emil