[Mesa-dev] [PATCH 1/9] i965/dri: Rewrite comment for intelCreateBuffer

Chad Versace chadversary at chromium.org
Fri May 26 22:15:06 UTC 2017


The old comment pinned this function to X11 windows. In reality, this
function serves more than X11 and more than just windows.
---
 src/mesa/drivers/dri/i965/intel_screen.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c
index 9842de6742..5de6f18b84 100644
--- a/src/mesa/drivers/dri/i965/intel_screen.c
+++ b/src/mesa/drivers/dri/i965/intel_screen.c
@@ -1152,7 +1152,11 @@ intelDestroyScreen(__DRIscreen * sPriv)
 
 
 /**
- * This is called when we need to set up GL rendering to a new X window.
+ * Create a gl_framebuffer and attach it to __DRIdrawable::driverPrivate.
+ *
+ *_This implements driDriverAPI::createNewDrawable, which the DRI layer calls
+ * when creating a EGLSurface, GLXDrawable, or GLXPixmap. Despite the name,
+ * this does not allocate GPU memory.
  */
 static GLboolean
 intelCreateBuffer(__DRIscreen *dri_screen,
-- 
2.13.0



More information about the mesa-dev mailing list