[Mesa-dev] [PATCH] llvmpipe: add LP_NEW_GS flag for updating vertex info

[Jose Fonseca]

On 27/05/17 03:35, sroland at vmware.com wrote:
> From: Roland Scheidegger <sroland at vmware.com>
> 
> The vertex information we compute here is really dependent on the last
> stage before FS. It just happened to work most of the time because new
> GS tend to come with new VS and/or FS...
> (The LP_NEW_GS flag was previously set but never used.)
> ---
>   src/gallium/drivers/llvmpipe/lp_state_derived.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/gallium/drivers/llvmpipe/lp_state_derived.c b/src/gallium/drivers/llvmpipe/lp_state_derived.c
> index fa9d4fb..3e75d44 100644
> --- a/src/gallium/drivers/llvmpipe/lp_state_derived.c
> +++ b/src/gallium/drivers/llvmpipe/lp_state_derived.c
> @@ -194,6 +194,7 @@ void llvmpipe_update_derived( struct llvmpipe_context *llvmpipe )
>      /* This needs LP_NEW_RASTERIZER because of draw_prepare_shader_outputs(). */
>      if (llvmpipe->dirty & (LP_NEW_RASTERIZER |
>                             LP_NEW_FS |
> +                          LP_NEW_GS |
>                             LP_NEW_VS))
>         compute_vertex_info(llvmpipe);
>   
> 

Great find.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>