[Mesa-dev] [PATCH] svga: fix git_sha1.h include path in Android.mk

[Mauro Rossi]

2017-05-28 16:46 GMT+02:00 Rob Herring <robh at kernel.org>:

> On Fri, May 26, 2017 at 10:15 AM, Mauro Rossi <issor.oruam at gmail.com>
> wrote:
> > Fixes the following building error:
> >
> > external/mesa/src/gallium/drivers/svga/svga_screen.c:26:10:
> > fatal error: 'git_sha1.h' file not found
> >          ^
> > 1 error generated.
> > ---
> >  src/gallium/drivers/svga/Android.mk | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/gallium/drivers/svga/Android.mk
> b/src/gallium/drivers/svga/Android.mk
> > index c50743d509..d19bd59bfe 100644
> > --- a/src/gallium/drivers/svga/Android.mk
> > +++ b/src/gallium/drivers/svga/Android.mk
> > @@ -30,7 +30,9 @@ include $(CLEAR_VARS)
> >
> >  LOCAL_SRC_FILES := $(C_SOURCES)
> >
> > -LOCAL_C_INCLUDES := $(LOCAL_PATH)/include
> > +LOCAL_C_INCLUDES := \
> > +       $(LOCAL_PATH)/include \
> > +       $(call generated-sources-dir-for,STATIC_LIBRARIES,libmesa_
> dricore,,)/main
>
> Add this path to LOCAL_EXPORT_C_INCLUDE_DIRS in libmesa_dricore and
> add libmesa_dricore as a static lib here instead.
>
> Rob
>

Hi Rob,
just a few questions,

why should we export the header which is artificially associated to
libmesa_dricore
and why treat this as a 'fake dependency'? The LOCAL_C_INCLUDE should
suffice

What is benefit in doing this? What is the drawback in using the android
macro created for this purpose?
Thanks

Mauro
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170528/9939cebe/attachment.html>