[Mesa-dev] [PATCH 02/30] i965/surface_state: Images can't handle CCS at all

[Jason Ekstrand]

On Tue, May 30, 2017 at 12:14 AM, Pohjolainen, Topi <
topi.pohjolainen at gmail.com> wrote:

> On Fri, May 26, 2017 at 04:30:06PM -0700, Jason Ekstrand wrote:
> > ---
> >  src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > index a0fed60..f37dd93 100644
> > --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > @@ -1752,12 +1752,12 @@ update_image_surface(struct brw_context *brw,
> >              };
> >
> >              const int surf_index = surf_offset -
> &brw->wm.base.surf_offset[0];
> > -            const bool unresolved = intel_miptree_has_color_unresolved(
> > -                                       mt, view.base_level, view.levels,
> > -                                       view.base_array_layer,
> view.array_len);
> > -            const int flags = unresolved ? 0 :
> INTEL_AUX_BUFFER_DISABLED;
> > -            brw_emit_surface_state(brw, mt, flags, mt->target, view,
> > -                                   tex_mocs[brw->gen],
> > +            assert(!intel_miptree_has_color_unresolved(mt,
> > +                                                       view.base_level,
> 1,
>
> Here you switch to '1' instead of view.levels?
>

which is set to 1 above... That said, I'm happy to switch it back.


> > +
>  view.base_array_layer,
> > +                                                       view.array_len));
> > +            brw_emit_surface_state(brw, mt, INTEL_AUX_BUFFER_DISABLED,
> > +                                   mt->target, view, tex_mocs[brw->gen],
> >                                     surf_offset, surf_index,
> >                                     I915_GEM_DOMAIN_SAMPLER,
> >                                     access == GL_READ_ONLY ? 0 :
> > --
> > 2.5.0.400.gff86faf
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170530/70f269c1/attachment.html>