[Mesa-dev] [PATCH 16/16] i965: Enable tiled memcpy tex image path on non-LLC

Kenneth Graunke kenneth at whitecape.org
Tue May 30 18:22:08 UTC 2017


On Wednesday, May 24, 2017 1:04:58 PM PDT Matt Turner wrote:
> ---
>  src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri/i965/intel_tex_subimage.c
> index 7acb3d3..2aead41 100644
> --- a/src/mesa/drivers/dri/i965/intel_tex_subimage.c
> +++ b/src/mesa/drivers/dri/i965/intel_tex_subimage.c
> @@ -98,8 +98,7 @@ intel_texsubimage_tiled_memcpy(struct gl_context * ctx,
>      * with _mesa_image_row_stride. However, before removing the restrictions
>      * we need tests.
>      */
> -   if (!brw->has_llc ||
> -       !(type == GL_UNSIGNED_BYTE || type == GL_UNSIGNED_INT_8_8_8_8_REV) ||
> +   if (!(type == GL_UNSIGNED_BYTE || type == GL_UNSIGNED_INT_8_8_8_8_REV) ||
>         !(texImage->TexObject->Target == GL_TEXTURE_2D ||
>           texImage->TexObject->Target == GL_TEXTURE_RECTANGLE) ||
>         pixels == NULL ||
> 

Sounds like we should hold off on this, based on Chris's comments.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170530/4d350069/attachment.sig>


More information about the mesa-dev mailing list