[Mesa-dev] [PATCH] radv: Revert HTILE reset word to 0xFFFFFFFF.

[Bas Nieuwenhuizen]

Dyanamic lighting stops working in the benchmark.

Not entirely root caused yet, I actually suspect this unhides a bug,
in that 0xffffffff might have cleared something that 0x30f doesn't (If
I completely disable the transition, which should be valid because we
always have a decompressed HTILE here, it also results in the
regression). Still looking at it, but in the meantime I'd like to
revert it as it breaks a game while AFAIK not fixing any yet.

On Wed, May 31, 2017 at 12:33 AM, Marek Olšák <maraeo at gmail.com> wrote:
> How did it regress it?
>
> Marek
>
> On Tue, May 30, 2017 at 11:06 PM, Bas Nieuwenhuizen
> <bas at basnieuwenhuizen.nl> wrote:
>> 0x30f regressed mad max.
>>
>> Signed-off-by: Bas Nieuwenhuizen <basni at google.com>
>> Fixes: df91abfe5af "radv: Use correct clear words for HTILE."
>> ---
>>  src/amd/vulkan/radv_cmd_buffer.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
>> index 66610e5233f..2ed93564b96 100644
>> --- a/src/amd/vulkan/radv_cmd_buffer.c
>> +++ b/src/amd/vulkan/radv_cmd_buffer.c
>> @@ -3030,7 +3030,7 @@ static void radv_handle_depth_image_transition(struct radv_cmd_buffer *cmd_buffe
>>                 radv_initialize_htile(cmd_buffer, image, range, 0);
>>         } else if (!radv_layout_is_htile_compressed(image, src_layout, src_queue_mask) &&
>>                    radv_layout_is_htile_compressed(image, dst_layout, dst_queue_mask)) {
>> -               radv_initialize_htile(cmd_buffer, image, range, 0x0000030f);
>> +               radv_initialize_htile(cmd_buffer, image, range, 0xffffffff);
>>         } else if (radv_layout_is_htile_compressed(image, src_layout, src_queue_mask) &&
>>                    !radv_layout_is_htile_compressed(image, dst_layout, dst_queue_mask)) {
>>                 VkImageSubresourceRange local_range = *range;
>> --
>> 2.13.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev