[Mesa-dev] [PATCH] Android: major/minor/makedev live in <sys/sysmacros.h>

[Emil Velikov]

On 30 May 2017 at 17:51, Rob Herring <robh at kernel.org> wrote:
> On Tue, May 30, 2017 at 11:46 AM, Mauro Rossi <issor.oruam at gmail.com> wrote:
>>
>>
>> 2017-05-30 14:23 GMT+02:00 Rob Herring <robh at kernel.org>:
>>>
>>> sysmacros.h was getting implicitly included in types.h until recently in
>>> AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h.
>>>
>>> Signed-off-by: Rob Herring <robh at kernel.org>
>>> ---
>>>  Android.common.mk | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Android.common.mk b/Android.common.mk
>>> index b2bb11a74c17..8496c6ec09ce 100644
>>> --- a/Android.common.mk
>>> +++ b/Android.common.mk
>>> @@ -65,6 +65,7 @@ LOCAL_CFLAGS += \
>>>         -DHAVE_DLOPEN \
>>>         -DHAVE_DL_ITERATE_PHDR \
>>>         -DTEXTURE_FLOAT_ENABLED \
>>> +       -DMAJOR_IN_SYSMACROS \
>>>         -fvisibility=hidden \
>>>         -Wno-sign-compare
>>>
>>> --
>>> 2.11.0
>>>
>>
>> One question: is there any rule to add the definitions in alphabetical
>> order?
>
> I don't think so. It's not already in alphabetical order.
>
I concur. Don't think there's any benefit in sorting it, but if others
disagree - patches welcome ;-)

-Emil