[Mesa-dev] [PATCH v2 2/5] r600: remove custom and incomplete OpenCL code paths

[Jan Vesely]

On Wed, 2017-05-31 at 13:33 +0100, Emil Velikov wrote:
> On 29 May 2017 at 16:33, Marek Olšák <maraeo at gmail.com> wrote:
> > The "ac" functions could also be forked and put into r600 if people
> > want to preserve the OpenCL support. That would remove the dependency
> > on "ac".
> > 

I thought amdgpu.a was supposed to be shared by both, is there a way to
 split off the GCN parts and still have reuse shared code?
I won't hide it, my intention is to rely on shared code as much as
possible and force others to care (same strategy with LLVM, but mesa
does not have a nice regression test suite).

> Any objections if we defer this to the person working on r600+OpenCL,
> or is that a must for the series?
> I'm slightly worried that a "fix the build" is going into "refactor
> driver X" :-\

what's wrong with adding an r600g+opencl on radeonsi dependency? if
it's "not used" enough to be removed, then it should be "not used"
enough to have non-standard dependency.

regards,
Jan


> 
> -Emil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170531/b9f6167f/attachment.sig>