[Mesa-dev] [PATCH 33/33] intel: add aubinator ui

[Dylan Baker]

Quoting Scott D Phillips (2017-11-01 10:30:09)
> Lionel Landwerlin <lionel.g.landwerlin at intel.com> writes:
> 
> > On 31/10/17 21:11, Scott D Phillips wrote:
> >>> +}
> >> [snip imgui]
> >>
> >> imgui seems to be the first instance of someone pasting a sizeable third
> >> party library into the repo.  I'm not sure how everyone feels about
> >> that. Unfortunately it seems like imgui isn't packaged by any distros
> >> that I can see either.
> >>
> >> Maybe we could do some meson wrap magic or something to pull it in
> >> without having to commit the code.
> >>
> > Copying seems to be the main way anybody is using it. Are you suggesting 
> > a submodule?
> 
> Right, something like making a 'wrap' for imgui that can go download and
> build the source:
> 
> http://mesonbuild.com/Wrap-dependency-system-manual.html
> 
> Really no idea if this is a great or terrible idea though. Dylan might
> have a better idea.
> 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev

I'm really not thrilled with the idea of pulling such a large fast moving
project into the tree either, though there is president, we have gtest in tree
already.

A wrap might be a good way to build it it, especially for an optional tool that
distros aren't expected to package. I wonder if upstream would take a meson build
specifically for this purpose? Would you like me to follow up with them and see
if that would be an option (meson feels [rightly] that it's preferable to try to
get a meson build into the upstream project before adding it to wrapdb)?

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171101/352746d1/attachment.sig>