[Mesa-dev] [PATCH 04/13] meson: build r600 driver

[Marc Dietrich]

Am Donnerstag, 2. November 2017, 13:03:17 CET schrieb Eric Engestrom:
> On Thursday, 2017-11-02 11:32:44 +0100, Marc Dietrich wrote:
> > Hi Dylan,
> > 
> > Am Mittwoch, 1. November 2017, 23:49:39 CET schrieb Dylan Baker:
> > > Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> > > Tested-by: Aaron Watry <awatry at gmail.com>
> > > ---
> > > 
> > >  meson.build                          |  20 ++++--
> > >  meson_options.txt                    |   2 +-
> > >  src/gallium/drivers/r600/meson.build | 128
> > > 
> > > +++++++++++++++++++++++++++++++++++ src/gallium/meson.build             
> > > |
> > > 
> > >  4 +-
> > >  src/gallium/targets/dri/meson.build  |   7 +-
> > >  5 files changed, 153 insertions(+), 8 deletions(-)
> > >  create mode 100644 src/gallium/drivers/r600/meson.build
> > 
> > r600 driver (on RS780) seems to work here (X starts, some games play).
> > During setup, I wondered why the vulkan drivers are enabled by default?
> > This is different from the autotools setup. Maybe there was a discussion
> > in the past about it and I just didn't got it.
> > 
> > Another thing which caught my eyes is the .so names are different.
> > Autotools produces a 3 number versions for all libs while meson generates
> > a
> > 
> >   - no version for libglapi
> >   - single number for libEGL_mesa.so.0, libGLESv2.so.2,libGLX_mesa.so.0
> >   - two versions for libGLESv1_CM.so.1.1
> >   - there numbers for libOSMesa.so.8.0.0, and libwayland-egl.so.1.0.0
> 
> meson adds as many numbers for the .so filename versions as are given in
> the `version` field of shared_library(). For instance, GLESv2 has
> `version : '2'`, while wayland-egl has `version : '1.0.0'`.
> 
> It's trivially easy to fix, but the question is: does it matter? Does
> anything use more than the major number? (Honest question, I simply
> don't know)
> Might be worth normalizing to either "always major.minor.patch" or
> "only the non-zero", but afaiu it doesn't matter which one we pick.

not sure if it matters. I just always blindly call "make/ninja install" which 
leads to two libraries with the same name in /usr/lib*, one from autotools and 
one from meson and ldconfig will gripe. But not really a problem for me.

Marc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171102/21285067/attachment.sig>