[Mesa-dev] [PATCH v2 11/11] intel: add aubinator ui

[Dylan Baker]

Quoting Lionel Landwerlin (2017-11-01 11:12:18)
[snip]
>  
> +if with_intel_tools
> +  inc_imgui = include_directories('imgui')

since aubinator_ui is the only consumer of this include, why don't we just put
the call to include_directories in the argument to the executable?

> +  aubinator_ui = executable(
> +    'aubinator_ui',
> +    files('aubinator_ui.cpp',
> +          'aubinator_imgui_widgets.cpp',
> +          'imgui/imgui.cpp',
> +          'imgui/imgui_demo.cpp',
> +          'imgui/imgui_draw.cpp',
> +          'imgui/imgui_impl_gtk3_cogl.cpp',
> +          'memory.c',
> +          'disasm.c',),
> +    dependencies : [dep_aubinator_ui, dep_expat, dep_zlib, dep_dl, dep_thread, dep_m],
> +    include_directories : [inc_common, inc_intel, inc_imgui],
> +    link_with : [libisl, libintel_common, libintel_compiler, libmesa_util],
> +    c_args : [c_vis_args, no_override_init_args],
> +    cpp_args : cpp_vis_args,
> +    build_by_default : false,
> +  )
> +endif
> +

It seems odd to me to guard an executable that has build_by_default false.
Since it's a developer tool, I think it's fine to let compilation fail if they
ninja src/intel/tools/aubinator_ui, or you should remove the build_by_default
and just let the guard toggle it.

Dylan

>  aubinator_error_decode = executable(
>    'aubinator_error_decode',
>    files('aubinator_error_decode.c', 'disasm.c', 'gen_disasm.h'),
> @@ -37,3 +58,12 @@ aubinator_error_decode = executable(
>    c_args : [c_vis_args, no_override_init_args],
>    build_by_default : false,
>  )
> +
> +memory_tests = executable(
> +  'memory_tests',
> +  files('memory.c'),
> +  include_directories : inc_common,
> +  link_with : libmesa_util,
> +  c_args : [c_vis_args, no_override_init_args, '-DBUILD_TESTS'],
> +  build_by_default : false,
> +)
> -- 
> 2.15.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171103/27a691b9/attachment-0001.sig>