[Mesa-dev] [PATCH] nv50,nvc0: enable using LOAD from constbuf

[Ilia Mirkin]

On Sun, Nov 5, 2017 at 1:13 PM, Tobias Klausmann
<tobias.johannes.klausmann at mni.thm.de> wrote:
>
> On 11/5/17 4:48 PM, Ilia Mirkin wrote:
>> This enables std430-style packing for UBOs which aren't otherwise marked
>> as std140.
>>
>> There might be small register lifetime changes as a result of removed
>> duplicate loads in some cases, but this seems worth it overall.
>
>
> A before/after shader-db run would be nice to see.
>
> Reviewed-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>

Not great =/

total instructions in shared programs : 6583617 -> 6588798 (0.08%)
total gprs used in shared programs    : 950832 -> 951158 (0.03%)
total shared used in shared programs  : 0 -> 0 (0.00%)
total local used in shared programs   : 15328 -> 15328 (0.00%)
total bytes used in shared programs   : 60366976 -> 60414152 (0.08%)

                local     shared        gpr       inst      bytes
    helped           0           0           0          61          61
      hurt           0           0         186         742         742

But not horrible either. Pretty much all of these would be resolved if
we had instruction scheduling... the loads happen somewhere up top and
can't propagate into e.g. exports, etc.

  -ilia