[Mesa-dev] [PATCH] radv: when loading regs no need to add buffer

[Samuel Pitoiset]

Fair enough.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 11/06/2017 03:18 AM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> The function that calls us has just added the buffer to the
> list already, no need to try and add it again.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>   src/amd/vulkan/radv_cmd_buffer.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 188b2fdafa3..590c41a7bf2 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -1327,7 +1327,6 @@ radv_load_depth_clear_regs(struct radv_cmd_buffer *cmd_buffer,
>   	if (!image->surface.htile_size)
>   		return;
>   
> -	cmd_buffer->device->ws->cs_add_buffer(cmd_buffer->cs, image->bo, 8);
>   
>   	radeon_emit(cmd_buffer->cs, PKT3(PKT3_COPY_DATA, 4, 0));
>   	radeon_emit(cmd_buffer->cs, COPY_DATA_SRC_SEL(COPY_DATA_MEM) |
> @@ -1411,7 +1410,6 @@ radv_load_color_clear_regs(struct radv_cmd_buffer *cmd_buffer,
>   		return;
>   
>   	uint32_t reg = R_028C8C_CB_COLOR0_CLEAR_WORD0 + idx * 0x3c;
> -	cmd_buffer->device->ws->cs_add_buffer(cmd_buffer->cs, image->bo, 8);
>   
>   	radeon_emit(cmd_buffer->cs, PKT3(PKT3_COPY_DATA, 4, cmd_buffer->state.predicating));
>   	radeon_emit(cmd_buffer->cs, COPY_DATA_SRC_SEL(COPY_DATA_MEM) |
>