[Mesa-dev] [PATCH] gallium: Guard assertions by NDEBUG instead of DEBUG

Eric Engestrom eric.engestrom at imgtec.com
Mon Nov 6 17:53:33 UTC 2017


On Monday, 2017-11-06 18:39:54 +0100, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
> 
> This matches the standard assert.h header.
> 
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

Guess we should audit every DEBUG in the codebase to make sure the right
one is used.

> ---
>  src/gallium/auxiliary/util/u_debug.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/auxiliary/util/u_debug.h b/src/gallium/auxiliary/util/u_debug.h
> index 63940b72253..d2ea89f59c1 100644
> --- a/src/gallium/auxiliary/util/u_debug.h
> +++ b/src/gallium/auxiliary/util/u_debug.h
> @@ -185,7 +185,7 @@ void _debug_assert_fail(const char *expr,
>   * For non debug builds the assert macro will expand to a no-op, so do not
>   * call functions with side effects in the assert expression.
>   */
> -#ifdef DEBUG
> +#ifndef NDEBUG
>  #define debug_assert(expr) ((expr) ? (void)0 : _debug_assert_fail(#expr, __FILE__, __LINE__, __FUNCTION__))
>  #else
>  #define debug_assert(expr) (void)(0 && (expr))
> -- 
> 2.15.0
> 


More information about the mesa-dev mailing list