[Mesa-dev] [PATCH v3] meson: implement default driver arguments

Dylan Baker dylan at pnwbakers.com
Mon Nov 6 18:27:25 UTC 2017


Quoting Eric Engestrom (2017-11-03 16:44:11)
> On Friday, 2017-11-03 18:09:01 +0000, Dylan Baker wrote:
> > This allows drivers to be set by OS/arch in a sane manner.
> > 
> > v2: - set _drivers to a list of drivers instead of manually assigning
> >       each with_*
> > v3: - Use "auto" instead of "default", which matches the value of other
> >       automatically configured options.
> >     - Set vulkan drivers as well
> >     - Add error message if no automatic drivers are known for a given
> >       arch/OS combo
> >     - use not(darwin or windows) instead of (linux or *bsd), which is
> >       probably more accurate (that way Solaris and other *nix systems
> >       aren't excluded)
> >     - rename softpipe to swrast, as swrast is the actual option name
> > 
> > cc: Eric Engestrom <eric at engestrom.ch>
> 
> Not sure about the duplicate error(), but that nitpick aside, this is:
> Reviewed-by: Eric Engestrom <eric at engestrom.ch>

I think it's nice to users to be clear why they're getting an error.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171106/045e41a8/attachment.sig>


More information about the mesa-dev mailing list