[Mesa-dev] [PATCH 2/2] r600g: use SIMPLE_FLOAT for blending to avoid NaNs in RTs

[Roland Scheidegger]

The patch doesn't help at all, but looks like a sensible thing to do anyway.

Reviewed-by: Roland Scheidegger <sroland at vmware.com>


Am 06.11.2017 um 05:22 schrieb Ilia Mirkin:
> Radeonsi also sets this flag.
> 
> Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D103544&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=_QIjpv-UJ77xEQY8fIYoQtr5qv8wKrPJc7v7_-CYAb0&m=yxACLhIHICZX46SSzjjTfuRdjgrY5Bxt4aJpAVfYMZw&s=VXVixXZEdahpJm__SRlvsGYPx9umOxP_Whefe0xyWXE&e=
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
> 
> This needs testing with the fbo-float-nan piglit that was recently added. Just
> guessing that this is the right flag to set here.
> 
>  src/gallium/drivers/r600/evergreen_state.c | 1 +
>  src/gallium/drivers/r600/r600_state.c      | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/evergreen_state.c
> index 96eb35a9818..131778dea9f 100644
> --- a/src/gallium/drivers/r600/evergreen_state.c
> +++ b/src/gallium/drivers/r600/evergreen_state.c
> @@ -1211,6 +1211,7 @@ static void evergreen_set_color_surface_common(struct r600_context *rctx,
>  		S_028C70_COMP_SWAP(swap) |
>  		S_028C70_BLEND_CLAMP(blend_clamp) |
>  		S_028C70_BLEND_BYPASS(blend_bypass) |
> +		S_028C70_SIMPLE_FLOAT(1) |
>  		S_028C70_NUMBER_TYPE(ntype) |
>  		S_028C70_ENDIAN(endian);
>  
> diff --git a/src/gallium/drivers/r600/r600_state.c b/src/gallium/drivers/r600/r600_state.c
> index c21e8dabb1f..0c331537460 100644
> --- a/src/gallium/drivers/r600/r600_state.c
> +++ b/src/gallium/drivers/r600/r600_state.c
> @@ -898,6 +898,7 @@ static void r600_init_color_surface(struct r600_context *rctx,
>  		S_0280A0_COMP_SWAP(swap) |
>  		S_0280A0_BLEND_BYPASS(blend_bypass) |
>  		S_0280A0_BLEND_CLAMP(blend_clamp) |
> +		S_0280A0_SIMPLE_FLOAT(1) |
>  		S_0280A0_NUMBER_TYPE(ntype) |
>  		S_0280A0_ENDIAN(endian);
>  
>