[Mesa-dev] gallium/r600 hw atomic support (v3)

[Gert Wollny]

Am Dienstag, den 07.11.2017, 16:30 +1000 schrieb Dave Airlie:
> This is the 3rd submission of the gallium/r600 hw atomic counter
> support.
> 
> This is fixes some rebase artifacts, removes the BUFFER decls from
> the TGSI, and fixes some indirect crashes in the r600 backend,

Well, I still get some crashes, i.e. piglits  

spec at arb_arrays_of_arrays@execution at atomic_counters@vs-indirect-index
spec at arb_arrays_of_arrays@execution at atomic_counters@fs-indirect-index

abort with stack smashing reported. Backtrace for vs-indirect-index is


 __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007ffff54a4439 in __GI_abort () at abort.c:89
#2  0x00007ffff54e448f in __libc_message (do_abort=do_abort at entry=2, fm
t=fmt at entry=0x7ffff55e4066 "*** %s ***: %s terminated\n") at
../sysdeps/posix/libc_fatal.c:175
#3  0x00007ffff5577027 in __GI___fortify_fail (msg=msg at entry=0x7ffff55e
404e "stack smashing detected") at fortify_fail.c:30
#4  0x00007ffff5576fe0 in __stack_chk_fail () at stack_chk_fail.c:28
#5  0x00007ffff2489822 in r600_draw_vbo (ctx=0x644740, info=<optimized
out>) at r600_state_common.c:2102
#6  0x00007ffff22b1d90 in u_vbuf_draw_vbo (mgr=0x7c9fa0,
info=<optimized out>) at util/u_vbuf.c:1142
#7  0x00007ffff1fabaa7 in st_draw_vbo (ctx=<optimized out>,
prims=0x7fffffffbe10, nr_prims=<optimized out>, ib=0x0,
index_bounds_valid=<optimized out>, 
    min_index=<optimized out>, max_index=<optimized out>,
tfb_vertcount=0x0, stream=0, indirect=0x0) at
state_tracker/st_draw.c:227
#8  0x00007ffff1f54060 in vbo_draw_arrays (ctx=ctx at entry=0x782a80, mode
=mode at entry=5, start=start at entry=0, count=count at entry=4, numInstances=n
umInstances at entry=1, 
    baseInstance=baseInstance at entry=0, drawID=0) at
vbo/vbo_exec_array.c:486
#9  0x00007ffff1f54662 in vbo_exec_DrawArrays (mode=5, start=0,
count=4) at vbo/vbo_exec_array.c:641
#10 0x00007ffff1e7970b in _mesa_unmarshal_DrawArrays (ctx=0x782a80,
cmd=0x7cae40, cmd=0x7cae40, cmd=0x7cae40) at
main/marshal_generated.c:26752
#11 _mesa_unmarshal_dispatch_cmd (ctx=ctx at entry=0x782a80, cmd=cmd at entry
=0x7cae40) at main/marshal_generated.c:42627
#12 0x00007ffff1e2ee9d in glthread_unmarshal_batch (job=0x7cad28,
thread_index=<optimized out>) at main/glthread.c:53
#13 0x00007ffff1e2f18b in _mesa_glthread_finish (ctx=ctx at entry=0x782a80
) at main/glthread.c:209
#14 0x00007ffff1e3ab34 in _mesa_marshal_GetIntegerv (pname=3074,
params=0x7fffffffbf84) at main/marshal_generated.c:37092
#15 0x00007ffff7b08733 in piglit_can_probe_ubyte () at
/home/gerddie/src/Freedesktop/piglit/tests/util/piglit-util-gl.c:1087
#16 0x00007ffff7b0b97c in piglit_probe_rect_rgba (x=x at entry=0, y=y at entr
y=0, w=250, h=250, expected=expected at entry=0x7fffffffc1d0)
    at /home/gerddie/src/Freedesktop/piglit/tests/util/piglit-util-
gl.c:1413
#17 0x000000000040b40b in piglit_display () at
/home/gerddie/src/Freedesktop/piglit/tests/shaders/shader_runner.c:3475
#18 0x00007ffff7b2acf5 in run_test (gl_fw=<optimized out>,
argc=<optimized out>, argv=<optimized out>)
    at /home/gerddie/src/Freedesktop/piglit/tests/util/piglit-
framework-gl/piglit_fbo_framework.c:52
#19 0x00007ffff7b175c3 in piglit_gl_test_run (argc=2, argv=argv at entry=0
x7fffffffd6e8, config=config at entry=0x7fffffffd590)
    at /home/gerddie/src/Freedesktop/piglit/tests/util/piglit-
framework-gl.c:223
#20 0x0000000000405fe7 in main (argc=<optimized out>,
argv=0x7fffffffd6e8) at
/home/gerddie/src/Freedesktop/piglit/tests/shaders/shader_runner.c:61


Best, 
Gert