[Mesa-dev] [PATCH 07/13] autotools: set XA versions in configure.ac and configure header file

[Emil Velikov]

On 7 November 2017 at 00:30, Dylan Baker <dylan at pnwbakers.com> wrote:
> Quoting Emil Velikov (2017-11-02 07:00:16)
>> On 1 November 2017 at 22:49, Dylan Baker <dylan at pnwbakers.com> wrote:
>> > Currently the versions are set in the header, and then sed is used to
>> > extract them, so that autotools can use them elsewhere.
>> >
>> > This is odd. Autotools is perfectly capable of configuring the header
>> > with the versions, and then they don't need to be extracted from the
>> > the header. This is cleaner and more obvious.
>> >
>> > Tested with make distcheck.
>> >
>> The idea was to have a place (like VERSION) to grab the version and
>> reuse across the board.
>> Since nobody the only other user can handle .in files - it makes sense
>> to remove the rather nasty construct.
>>
>>
>> > +XA_VERSION_MAJOR=2
>> > +AC_SUBST([XA_VERSION_MAJOR])
>> Please drop the _VERSION bit and temporary variables.
>
> XA_VERSION is used in the xatracker.pc file, do you want a separate change to
> replace that with major.minor.tiny? I can certainly add that to v2.
>
I'd leave XA_VERSION as-is same as XA_{MAJOR,MINOR,TINY} (no _VERSION)
as per the earlier example.
Those are cosmetic changes, which are better suited in separate patch.

Thanks
Emil