[Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

Dylan Baker dylan at pnwbakers.com
Tue Nov 7 22:28:54 UTC 2017


Quoting Eric Engestrom (2017-11-07 07:25:53)
> On Wednesday, 2017-11-01 13:49:03 -0700, Chad Versace wrote:
> > I tested this in a setup where the builddir was outside of the srcdir.
> > ---
> >  src/intel/vulkan/meson.build | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/src/intel/vulkan/meson.build b/src/intel/vulkan/meson.build
> > index ff24e304ef5..e8b7f407507 100644
> > --- a/src/intel/vulkan/meson.build
> > +++ b/src/intel/vulkan/meson.build
> > @@ -48,6 +48,18 @@ intel_icd = custom_target(
> >    install : true,
> >  )
> >  
> > +dev_icd = custom_target(
> > +  'dev_icd',
> > +  input : 'anv_icd.py',
> > +  output : 'dev_icd. at 0@.json'.format(target_machine.cpu()),
> 
> Strictly speaking, shouldn't that be `host_machine` [1] ?
> I don't see how one would do a canadian build of mesa though, so
> host == target should always be true.

That's my fault. There are (or were) a number of cases where I used target
instead of host, that can also be a follow up.

In any case:
Acked-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171107/c7320e59/attachment-0001.sig>


More information about the mesa-dev mailing list