[Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

[Chad Versace]

On Wed 08 Nov 2017, Jason Ekstrand wrote:
> On Wed, Nov 8, 2017 at 1:40 PM, Chad Versace <[1]chadversary at chromium.org>
> wrote:
> 
>     On Tue 07 Nov 2017, Dylan Baker wrote:
>     > Quoting Eric Engestrom (2017-11-07 07:25:53)
>     > > On Wednesday, 2017-11-01 13:49:03 -0700, Chad Versace wrote:
>     > > > I tested this in a setup where the builddir was outside of the
>     srcdir.
>     > > > ---
>     > > >  src/intel/vulkan/meson.build | 12 ++++++++++++
>     > > >  1 file changed, 12 insertions(+)
>     > > >
>     > > > diff --git a/src/intel/vulkan/meson.build b/src/intel/vulkan/
>     meson.build
>     > > > index ff24e304ef5..e8b7f407507 100644
>     > > > --- a/src/intel/vulkan/meson.build
>     > > > +++ b/src/intel/vulkan/meson.build
>     > > > @@ -48,6 +48,18 @@ intel_icd = custom_target(
>     > > >    install : true,
>     > > >  )
>     > > >
>     > > > +dev_icd = custom_target(
>     > > > +  'dev_icd',
>     > > > +  input : 'anv_icd.py',
>     > > > +  output : 'dev_icd. at 0@.json'.format(target_machine.cpu()),
>     > >
>     > > Strictly speaking, shouldn't that be `host_machine` [1] ?
>     > > I don't see how one would do a canadian build of mesa though, so
>     > > host == target should always be true.
>     >
>     > That's my fault. There are (or were) a number of cases where I used
>     target
>     > instead of host, that can also be a follow up.
>     >
>     > In any case:
>     > Acked-by: Dylan Baker <[2]dylan at pnwbakers.com>
> 
>     I build Mesa (with autotools) where host == x86_64 but target == armv7a.
> 
> 
> You're using dev_icd with a cross-compile?  Yikes!  I mean, it can work, but
> that's not what I would have expected.  Also, why are you building anv and
> targetting armv7a????  Does that even work?

Two many interacting topics!

Eric said: "I don't see how one would do a canadian build of mesa
though, so host == target should always be true". Mesa, not anvil.
I replied that I cross-compile Mesa for ARM.

On host-vs-target: My host machine and target machine are rarely the
same. But, for Anvil, of course, the two machines do always have the
same architecture.

Regardless, the icd filename should always contain the target
architecture, because run the icd *on the target*.