[Mesa-dev] [PATCH] i965: Enable disk shader cache by default

[Timothy Arceri]

Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

Mark may want to consider adding some of the once a day type CI runs for 
this. For example running the test suite for two consecutive runs on the 
same build so that the second run uses the shader cache and also a 
second run the uses MESA_GLSL=cache_fb to force testing of the cache 
fallback path.

On 09/11/17 11:58, Jordan Justen wrote:
> f9d5a7add42af5a2e4410526d1480a08f41317ae along with
> a16dc04ad51c32e5c7d136e4dd6273d983385d3f appears to have fixed the one
> known regression with shader cache. (Deus Ex instability.)
> 
> We should enable the shader cache by default to stabilize it before
> the next major Mesa release.
> 
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>   docs/relnotes/17.4.0.html                  | 2 +-
>   src/mesa/drivers/dri/i965/brw_disk_cache.c | 3 ---
>   2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/docs/relnotes/17.4.0.html b/docs/relnotes/17.4.0.html
> index f81b5bd62d3..48dcd5cce38 100644
> --- a/docs/relnotes/17.4.0.html
> +++ b/docs/relnotes/17.4.0.html
> @@ -44,7 +44,7 @@ Note: some of the new features are only available with certain drivers.
>   </p>
>   
>   <ul>
> -<li>Disk shader cache support for i965 when MESA_GLSL_CACHE_DISABLE environment variable is set to "0" or "false"</li>
> +<li>Disk shader cache support for i965</li>
>   </ul>
>   
>   <h2>Bug fixes</h2>
> diff --git a/src/mesa/drivers/dri/i965/brw_disk_cache.c b/src/mesa/drivers/dri/i965/brw_disk_cache.c
> index 853ea98af03..cd0524c5cbf 100644
> --- a/src/mesa/drivers/dri/i965/brw_disk_cache.c
> +++ b/src/mesa/drivers/dri/i965/brw_disk_cache.c
> @@ -420,9 +420,6 @@ void
>   brw_disk_cache_init(struct brw_context *brw)
>   {
>   #ifdef ENABLE_SHADER_CACHE
> -   if (env_var_as_boolean("MESA_GLSL_CACHE_DISABLE", true))
> -      return;
> -
>      char renderer[10];
>      MAYBE_UNUSED int len = snprintf(renderer, sizeof(renderer), "i965_%04x",
>                                      brw->screen->deviceID);
>