[Mesa-dev] [PATCH 15/17] main: Clear shader program data whenever ProgramBinary is called

Nicolai Hähnle nhaehnle at gmail.com
Thu Nov 9 11:04:48 UTC 2017


Patches 10-15:

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

On 09.11.2017 07:42, Jordan Justen wrote:
> The GL_ARB_get_program_binary extension spec says:
> 
>   "If ProgramBinary fails to load a binary, no error is generated, but
>    any information about a previous link or load of that program object
>    is lost."
> 
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>   src/mesa/main/shaderapi.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
> index 47a51279353..03e8488ccee 100644
> --- a/src/mesa/main/shaderapi.c
> +++ b/src/mesa/main/shaderapi.c
> @@ -2224,6 +2224,8 @@ _mesa_ProgramBinary(GLuint program, GLenum binaryFormat,
>      if (!shProg)
>         return;
>   
> +   _mesa_clear_shader_program_data(ctx, shProg);
> +
>      /* Section 2.3.1 (Errors) of the OpenGL 4.5 spec says:
>       *
>       *     "If a negative number is provided where an argument of type sizei or
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list