[Mesa-dev] [PATCH 1/2] glsl/es: precision qualifier doesn't need to match in UBOs

Samuel Iglesias Gonsálvez siglesias at igalia.com
Thu Nov 9 12:12:01 UTC 2017


I forgot to add here that GLSL ES 320 requires precisions to match for
default uniforms, but not for uniforms in UBOs. This spec change also
affects OpenGL ES 3.1 and OpenGL ES 3.0.

I fixed it locally.

Sam

On Thu, 2017-11-09 at 12:48 +0100, Samuel Iglesias Gonsálvez wrote:
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> ---
>  src/compiler/glsl/link_interface_blocks.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compiler/glsl/link_interface_blocks.cpp
> b/src/compiler/glsl/link_interface_blocks.cpp
> index 510d4f71bbe..c2c3b58f821 100644
> --- a/src/compiler/glsl/link_interface_blocks.cpp
> +++ b/src/compiler/glsl/link_interface_blocks.cpp
> @@ -114,7 +114,7 @@ intrastage_match(ir_variable *a,
>         */
>        if ((a->data.how_declared != ir_var_declared_implicitly ||
>             b->data.how_declared != ir_var_declared_implicitly) &&
> -          (!prog->IsES || prog->data->Version != 310 ||
> +          (!prog->IsES ||
>             interstage_member_mismatch(prog, a->get_interface_type(),
>                                        b->get_interface_type())))
>           return false;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171109/41ee4db9/attachment.sig>


More information about the mesa-dev mailing list