[Mesa-dev] [PATCH] i965: implement (un)mapImage

[Julien Isorce]

Hi Emil,

Thx for the suggestion about kmscube and piglit. I tried them and I have
sent a v3 patch.

Hi Chris,

I can see that in Ben's patch it calls brw_bo_unreference instead of
brw_bo_unmap.
Also the existing brw_bo_unmap is a no op (strange it is implemented as
just return 0)
Any idea ?

Thx
Julien


On 8 November 2017 at 17:18, Emil Velikov <emil.l.velikov at gmail.com> wrote:

> Hi Julien,
>
> On 8 November 2017 at 16:55, Julien Isorce <julien.isorce at gmail.com>
> wrote:
> > v2: add early return if (flag & MAP_INTERNAL_MASK)
> >
> > Already implemented for Gallium drivers.
> >
> > Useful for gbm_bo_(un)map.
> >
> > Tested by porting wayland/weston/clients/simple-dmabuf-drm.c to GBM.
> >
> Ben did a slightly different implementation a while back [1], but it
> never got merged due to shortage of review.
> Glad to see some interest on the topic.
>
> On the testing side - the ext_image_dma_buf_import piglit tests +
> kmscube should help, alongside your weston* case.
>
> HTH
> Emil
>
> [1] https://lists.freedesktop.org/archives/mesa-dev/2017-April/152646.html
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171109/b0ba92cd/attachment.html>