[Mesa-dev] [PATCH 4/5] r600: use ieee version of rsq

sroland at vmware.com sroland at vmware.com
Thu Nov 9 19:00:48 UTC 2017


From: Roland Scheidegger <sroland at vmware.com>

Both r600 and evergreen used the clamped version, whereas cayman used the
ieee one. I don't think there's a valid reason for this discrepancy, so let's
switch to the ieee version for r600 and evergreen too, since we generally
want to stick to ieee arithmetic.
With this, behavior for both rcp and rsq should now be the same for all of
r600, eg, cm, all using ieee versions (albeit note rsq retains the abs
behavior for everybody, which may not be a good idea ultimately).
---
 src/gallium/drivers/r600/r600_shader.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c
index 2ece2210a6..3f42654d13 100644
--- a/src/gallium/drivers/r600/r600_shader.c
+++ b/src/gallium/drivers/r600/r600_shader.c
@@ -4796,11 +4796,7 @@ static int tgsi_rsq(struct r600_shader_ctx *ctx)
 
 	memset(&alu, 0, sizeof(struct r600_bytecode_alu));
 
-	/* XXX:
-	 * For state trackers other than OpenGL, we'll want to use
-	 * _RECIPSQRT_IEEE instead.
-	 */
-	alu.op = ALU_OP1_RECIPSQRT_CLAMPED;
+	alu.op = ALU_OP1_RECIPSQRT_IEEE;
 
 	for (i = 0; i < inst->Instruction.NumSrcRegs; i++) {
 		r600_bytecode_src(&alu.src[i], &ctx->src[i], 0);
-- 
2.12.3



More information about the mesa-dev mailing list