[Mesa-dev] [PATCH 3/3] etnaviv: Add sampler TS support

[Wladimir J. van der Laan]

Hello Lucas,

On Thu, Nov 09, 2017 at 06:15:51PM +0100, Lucas Stach wrote:
> Hi Wladimir!

> > etna_resource_needs_flush is only called from two places - here, and
> > in resource_flush, where it also determines whether to do a
> > resolve-to-self, but before presenting the image. There it also only
> > makes sense to do if the resource has at least a valid TS.
> 
> Yes, this makes sense.
> 
> Also I've just tested this and I've seen some intermittent missing
> shadow tiles in the glmark2 shadow demo. Probably you are now missing
> the TS cache flush we would normally do before blitting the shadow
> image with the RS.

Thanks for testing!

I'll see if I can reproduce it. 

Good point about the TS, I expect that needs to be flushed before the texture
can be rendered from, so that sampler TS sees a consistent TS. 

Regards,
Wladimir