[Mesa-dev] [PATCH 16/17] util: Add Mesa ARB_get_program_binary helper functions

[Jose Fonseca]

On 10/11/17 03:40, Jordan Justen wrote:
> On 2017-11-09 08:07:57, Jose Fonseca wrote:
>> On 09/11/17 13:19, Emil Velikov wrote:
>>> Hi Jordan,
>>>
>>> On 9 November 2017 at 06:42, Jordan Justen <jordan.l.justen at intel.com> wrote:
>>>> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
>>>> ---
>>>>    src/util/Makefile.sources |   2 +
>>>>    src/util/meson.build      |   2 +
>>>>    src/util/program_binary.c | 322 ++++++++++++++++++++++++++++++++++++++++++++++
>>>>    src/util/program_binary.h |  91 +++++++++++++
>>>>    4 files changed, 417 insertions(+)
>>>>    create mode 100644 src/util/program_binary.c
>>>>    create mode 100644 src/util/program_binary.h
>>>>
>>>
>>>> +#include "zlib.h"
>>>> +
>>> Currently zlib is a dependency for !WIndows platforms.
>>> With this patch we add it to the Windows builds.
>>>
>>> Brian, Jose any ideas how we can get zlib on Windows?
>>>
>>> Thanks
>>> Emil
>>>
>>
>> Thanks for the heads up Emil!
>>
>> The most effective way to get zlib on Windows would be to bundle the
>> source code in mesa/src/zlib.
>>
>> But it would be much simpler we did not add zlib as a required dependency.
>>
>> Could we use some other checksum/hash?
>>
>> Or instead of bundling the whole zlib, we could just bundle crc
>> implementation.  I'm sure there are many BDS/MIT licensed out there.
>> I've used some in apitrace --
>> https://github.com/apitrace/apitrace/tree/master/thirdparty/crc32c
> 
> We have bundled crc32 already.
> 
> I compress the program, but it is optional, and compression is not
> used if it actually doesn't produce a smaller result. I'll update the
> series such that if zlib is not available, then we'll always produce
> an uncompressed result.
> 
> -Jordan
> 

Perfect.  Thanks.

Jose