[Mesa-dev] [PATCH 00/17] i965 ARB_get_program_binary support

[Jordan Justen]

On 2017-11-10 23:46:39, Timothy Arceri wrote:
> On 09/11/17 21:46, Timothy Arceri wrote:
> > On 09/11/17 17:42, Jordan Justen wrote:
> >> git://people.freedesktop.org/~jljusten/mesa i965-get-program-binary-v1
> >>
> >> This series adds i965 support for ARB_get_program_binary with greater
> >> than 0 supported formats. Today we support this extension, but
> >> advertise support for 0 formats. This series allows i965 to advertise
> >> support for 1 format.
> >>
> >> This series defines a common Mesa format for ARB_get_program_binary,
> >> along with helper functions to read and write the format. We also
> >> define an OpenGL Mesa spec to be used with this binary format. The
> >> binary saved can only be reloaded on the exact same Mesa build using
> >> the exact same hardware.
> >>
> >> The i965 implementation saves out a serialize nir represenation of the
> >> program. Later we can add support for saving the gen binary program as
> >> well. (We will still need the nir program for state based recompiles.)
> >>
> >> This implementation passes piglit, deqp and glcts functions.
> > 
> > Nice to see this finally implemented :) Do the test suites actually test 
> > the extension? I'm assuming piglit doesn't.
> > 
> >> It also
> >> works with Dota 2, which appears to make use of the extension.
> > 
> > Would be interesting to try Dead Island with this if you have it. It 
> > should fix this bug: https://bugs.freedesktop.org/show_bug.cgi?id=85564
> 
> I can confirm Dead Island now works great (fast load times and no crash) 
> with this series. Great work!
> 
> I'm going to resolve that bug as not our bug as it is clearly a game bug.
> 
> > 
> > Dying Light is another game that uses the extension.

Nice! Thanks for checking that, as I don't own either of these games.

-Jordan