[Mesa-dev] [PATCH 09/11] intel/tools/error: Decode shaders while decoding batch commands.

[Chris Wilson]

Quoting Kenneth Graunke (2017-11-12 08:35:10)
> This makes aubinator_error_decode's shader dumping work like aubinator.
> Instead of printing them after the fact, it prints them right inside the
> 3DSTATE_VS/HS/DS/GS/PS packet that references them.  This saves you the
> effort of cross-referencing things and jumping back and forth.
> 
> It also reduces a bunch of book-keeping, and eliminates the limitation
> that we could only handle 4096 programs.  That code was also broken and
> failed to print any shaders if there were under 4096 programs.

The patch reads ok, but at this point I'll hand over to Lionel as we are
past the horrible parsing of the error-state and into the decode.

May I request that you also start a wishlist inside aubinator about
changes to the error state (both contents and format) that will aide
debugging hangs. Also think about Vk, I presume there we will need much
more to translate it back to the Vk API as the consumer of error states
will not be so much as the driver developer but app/toolkit developer.
That presents a fresh challenge!
-Chris