[Mesa-dev] [PATCH] intel/genxml: Delete empty groups

Jason Ekstrand jason at jlekstrand.net
Sun Nov 12 23:43:52 UTC 2017


They serve no purpose other than to just fill empty space in the packet
so each dword has something.  Just disallowing empty groups is a bit
easier on some of the tools.  This does not change the generated packing
headers in any way.

Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
---
 src/intel/genxml/gen6.xml  | 2 --
 src/intel/genxml/gen7.xml  | 2 --
 src/intel/genxml/gen75.xml | 2 --
 src/intel/genxml/gen8.xml  | 2 --
 4 files changed, 8 deletions(-)

diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml
index 96f4be7..971cd48 100644
--- a/src/intel/genxml/gen6.xml
+++ b/src/intel/genxml/gen6.xml
@@ -416,8 +416,6 @@
     <field name="Viewport Matrix Element m30" start="96" end="127" type="float"/>
     <field name="Viewport Matrix Element m31" start="128" end="159" type="float"/>
     <field name="Viewport Matrix Element m32" start="160" end="191" type="float"/>
-    <group count="2" start="192" size="32">
-    </group>
   </struct>
 
   <struct name="BLEND_STATE_ENTRY" length="2">
diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml
index cc17018..9e34c16 100644
--- a/src/intel/genxml/gen7.xml
+++ b/src/intel/genxml/gen7.xml
@@ -469,8 +469,6 @@
     <field name="X Max Clip Guardband" start="288" end="319" type="float"/>
     <field name="Y Min Clip Guardband" start="320" end="351" type="float"/>
     <field name="Y Max Clip Guardband" start="352" end="383" type="float"/>
-    <group count="4" start="384" size="32">
-    </group>
   </struct>
 
   <struct name="BLEND_STATE_ENTRY" length="2">
diff --git a/src/intel/genxml/gen75.xml b/src/intel/genxml/gen75.xml
index cb408a2..e2fd856 100644
--- a/src/intel/genxml/gen75.xml
+++ b/src/intel/genxml/gen75.xml
@@ -488,8 +488,6 @@
     <field name="X Max Clip Guardband" start="288" end="319" type="float"/>
     <field name="Y Min Clip Guardband" start="320" end="351" type="float"/>
     <field name="Y Max Clip Guardband" start="352" end="383" type="float"/>
-    <group count="4" start="384" size="32">
-    </group>
   </struct>
 
   <struct name="BLEND_STATE_ENTRY" length="2">
diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml
index 99c4aca..a89283d 100644
--- a/src/intel/genxml/gen8.xml
+++ b/src/intel/genxml/gen8.xml
@@ -1940,8 +1940,6 @@
     <field name="3D Command Opcode" start="24" end="26" type="uint" default="1"/>
     <field name="3D Command Sub Opcode" start="16" end="23" type="uint" default="28"/>
     <field name="DWord Length" start="0" end="7" type="uint" default="7"/>
-    <group count="4" start="32" size="32">
-    </group>
     <field name="8x Sample7 X Offset" start="188" end="191" type="u0.4"/>
     <field name="8x Sample7 Y Offset" start="184" end="187" type="u0.4"/>
     <field name="8x Sample6 X Offset" start="180" end="183" type="u0.4"/>
-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list