[Mesa-dev] [PATCH v2] etnaviv: automake, meson: include common_3d.xml.h in the sources lists

Eric Engestrom eric.engestrom at imgtec.com
Mon Nov 13 10:57:53 UTC 2017


On Monday, 2017-11-13 10:20:24 +0100, Juan A. Suarez Romero wrote:
> Eric, could you grant R-b if you think this is fine?

Sure, sorry I forgot:
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

Wladimir, Christian: while looking at f1e1c60ff6, I noticed
state_blt.xml.h and texdesc_3d.xml.h were also added, but don't seem to
be used anywhere; were those files added by mistake?

> 
> Thanks in advance!
> 
> 	J.A.
> 
> 
> On Tue, 2017-11-07 at 16:55 +0100, Juan A. Suarez Romero wrote:
> > v2: include the file also in the meson.build (Eric Engestrom).
> > 
> > Fixes: f1e1c60ff6 ("etnaviv: Update from rnndb")
> > ---
> >  src/gallium/drivers/etnaviv/Makefile.sources | 1 +
> >  src/gallium/drivers/etnaviv/meson.build      | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/src/gallium/drivers/etnaviv/Makefile.sources b/src/gallium/drivers/etnaviv/Makefile.sources
> > index ea8df807f66..aafcc380aa5 100644
> > --- a/src/gallium/drivers/etnaviv/Makefile.sources
> > +++ b/src/gallium/drivers/etnaviv/Makefile.sources
> > @@ -1,6 +1,7 @@
> >  C_SOURCES :=  \
> >  	hw/cmdstream.xml.h \
> >  	hw/common.xml.h \
> > +	hw/common_3d.xml.h \
> >  	hw/isa.xml.h \
> >  	hw/state_3d.xml.h \
> >  	hw/state.xml.h \
> > diff --git a/src/gallium/drivers/etnaviv/meson.build b/src/gallium/drivers/etnaviv/meson.build
> > index f4ae57b4a75..b9c5e47d197 100644
> > --- a/src/gallium/drivers/etnaviv/meson.build
> > +++ b/src/gallium/drivers/etnaviv/meson.build
> > @@ -21,6 +21,7 @@
> >  files_etnaviv = files(
> >    'hw/cmdstream.xml.h',
> >    'hw/common.xml.h',
> > +  'hw/common_3d.xml.h',
> >    'hw/isa.xml.h',
> >    'hw/state_3d.xml.h',
> >    'hw/state.xml.h',


More information about the mesa-dev mailing list