[Mesa-dev] [Mesa-stable] [PATCH 1/2] configure: Demote gbm dependency error to warning

Emil Velikov emil.l.velikov at gmail.com
Mon Nov 13 14:13:46 UTC 2017


On 12 November 2017 at 07:15, sguttula <suresh.guttula at amd.com> wrote:
> In case of chromiumos, minigbm is used in place of mesa-gbm.
> So to make runtime dependency works fine ,ignoring this
> compile time dependency check on mesa-gbm
>
> Cc: mesa-stable at lists.freedesktop.org
> Cc: Emil Velikov <emil.velikov at collabora.com>
> Cc: Deepak Sharma <deepak.sharma at amd.com>
>
> Signed-off-by: sguttula <suresh.guttula at amd.com>
> Reviewed-by: Deepak Sharma <deepak.sharma at amd.com>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  mode change 100644 => 100755 configure.ac
>
> diff --git a/configure.ac b/configure.ac
> old mode 100644
> new mode 100755
> index bbabf3b..292217c
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1735,7 +1735,7 @@ for plat in $platforms; do
>
>      drm)
>          test "x$enable_gbm" = "xno" &&
> -                AC_MSG_ERROR([EGL platform drm needs gbm])
> +                AC_MSG_WARN([EGL platform drm needs gbm])
Since it's no longer required, I'd reword the commit message a bit.
Say "EGL platform drm requires gbm implementation at runtime"?

The patch should be the final in the series, otherwise we'll get an
interment breakage.

Thanks
Emil


More information about the mesa-dev mailing list